Repository navigation
ZOOKEEPER-5108: Client SASL settings set to true with trailing whitespace are read as false - #2484
Merged
Merged
Conversation
…pace are read as false Use the existing trimmed boolean configuration accessor for SASL client enablement and hostname canonicalization, and cover both trailing-space cases. Generated-by: Pi 1.4.0 (openai-codex/gpt-6-luna)
kezhuw
approved these changes
Oct 27, 2026
Contributor
|
Merged to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ZOOKEEPER-5108
ZKClientConfig.isSaslClientEnabled()and SASL hostname canonicalization now use the existingZKConfig.getBooleanaccessor, which trims property values before parsing. This keeps explicitly configuredtruevalues consistent with the existing configuration behavior.Regression coverage verifies trailing whitespace for both SASL settings.
Validation:
ClientCanonicalizeTest: 7 tests passed.SaslClientTest: 1 test passed.-Pfull-buildMaven verification on native Windows/JDK 25 with tests skipped: Apache RAT passed (0 unapproved/unknown files), SpotBugs passed (0 bugs/errors), Checkstyle passed (0 violations), and the Jute/server sources and tests compiled. Javadoc emitted warnings in unchanged source files; the build succeeded.git diff --checkpassed.Generated-by: Pi 1.4.0 (openai-codex/gpt-6-luna)