Skip to content

Revert "ZOOKEEPER-4966: Decouple ZKConfig from QuorumPeerConfig.ConfigException - #2490

Open
kezhuw wants to merge 1 commit into
apache:masterfrom
kezhuw:ZOOKEEPER-4966-revert
Open

kezhuw wants to merge 1 commit into
apache:masterfrom
kezhuw:ZOOKEEPER-4966-revert

Conversation

@kezhuw

@kezhuw kezhuw commented Nov 4, 2026

Copy link
Copy Markdown
Member

This reverts commit 3ae8e77.

It drops QuorumPeerConfig.ConfigException in favor of o.a.z.common.ConfigException to decouple ZKClientConfig from QuorumPeerConfig. Both ZKClientConfig and QuorumPeerConfig are tagged with @InterfaceAudience.Public. We should not shipped it in minor version bump.

…nfigException`"

This reverts commit 3ae8e77.

It drops `QuorumPeerConfig.ConfigException` in favor of
`o.a.z.common.ConfigException` to decouple `ZKClientConfig` from
`QuorumPeerConfig`. Both `ZKClientConfig` and `QuorumPeerConfig` are
tagged with `@InterfaceAudience.Public`. We should not shipped it in
minor version bump.

@anmolnar anmolnar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants