Repository navigation
Conversation
…rupts session state Calling threads close the client socket directly during server reconfigurations or failed async writes, bypassing proper cleanup and producing invalid internal states. This triggers several race conditions: healthy connections are dropped when the wake-up pipe backs up, pending requests are routed to new servers prematurely, watchers are exposed to inconsistent states, and authentication failures are masked. The fix is to manage the lifecycle strictly in the I/O driver. Calling threads no longer close sockets or mutate client state themselves. Instead they set a disconnect request flag and signal the I/O thread. The driver handles the teardown deterministically, notifying watchers of a reconnecting state, cleanly failing in-flight requests with connection loss, and hardening the wake up path against pipe congestion and signal interruptions. Add Zookeeper_operations tests testServerListChangeFailsPendingRequests, testSendFailureDefersTeardown, testPingSendFailureTearsDown, testServerListChangeKeepsAuthFailedState (ST), testServerListChangeDuringSessionEstablishment and testFullWakeupPipeKeepsConnection (MT). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling threads close the client socket directly during server reconfigurations or failed async writes, bypassing proper cleanup and producing invalid internal states. This triggers several race conditions: healthy connections are dropped when the wake-up pipe backs up, pending requests are routed to new servers prematurely, watchers are exposed to inconsistent states, and authentication failures are masked.
The fix is to manage the lifecycle strictly in the I/O driver. Calling threads no longer close sockets or mutate client state themselves. Instead they set a disconnect request flag and signal the I/O thread. The driver handles the teardown deterministically, notifying watchers of a reconnecting state, cleanly failing in-flight requests with connection loss, and hardening the wake up path against pipe congestion and signal interruptions.
Add Zookeeper_operations tests testServerListChangeFailsPendingRequests, testSendFailureDefersTeardown, testPingSendFailureTearsDown, testServerListChangeKeepsAuthFailedState (ST),
testServerListChangeDuringSessionEstablishment and testFullWakeupPipeKeepsConnection (MT).