Skip to content

feat(toon): toon encoder component - #7710

Closed
soyuka wants to merge 5 commits into
api-platform:mainfrom
soyuka:toon
Closed

feat(toon): toon encoder component#7710
soyuka wants to merge 5 commits into
api-platform:mainfrom
soyuka:toon

Conversation

@soyuka

@soyuka soyuka commented Jan 28, 2026

Copy link
Copy Markdown
Member
Q A
Branch? main
Tickets na
License MIT
Doc PR na

Add a toon encoder

@soyuka soyuka mentioned this pull request Jan 28, 2026
Merged
@stale

stale Bot commented Mar 29, 2026

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Mar 29, 2026
@stale stale Bot closed this Apr 5, 2026
@soyuka soyuka reopened this Apr 6, 2026
@stale stale Bot removed the stale label Apr 6, 2026
soyuka added a commit to soyuka/core that referenced this pull request May 5, 2026
@soyuka
refactor: split normalizer/denormalizer
69b0889 
| Q             | A
| ------------- | ---
| Branch?       | main
| Tickets       | prerequisite for api-platform#7710
| License       | MIT
| Doc PR        | ∅

Extract a dedicated ItemDenormalizer alongside each ItemNormalizer
(generic Serializer, JSON-LD, JSON:API) with shared logic in an
ItemNormalizerTrait. Existing normalizers keep their denormalize
support via the trait for BC. Symfony and Laravel DI register the
new denormalizers.
soyuka added a commit to soyuka/core that referenced this pull request May 5, 2026
@soyuka
refactor: split normalizer/denormalizer
3489265 
| Q             | A
| ------------- | ---
| Branch?       | main
| Tickets       | prerequisite for api-platform#7710
| License       | MIT
| Doc PR        | ∅

Extract a dedicated ItemDenormalizer alongside each ItemNormalizer
(generic Serializer, JSON-LD, JSON:API) with shared logic in an
ItemNormalizerTrait. Existing normalizers keep their denormalize
support via the trait for BC. Symfony and Laravel DI register the
new denormalizers.
soyuka and others added 5 commits May 5, 2026 14:42
@soyuka
refactor: split normalizer/denormalizer
a23a084 
| Q             | A
| ------------- | ---
| Branch?       | main
| Tickets       | prerequisite for api-platform#7710
| License       | MIT
| Doc PR        | ∅

Extract a dedicated ItemDenormalizer alongside each ItemNormalizer
(generic Serializer, JSON-LD, JSON:API) with shared logic in an
ItemNormalizerTrait. Existing normalizers keep their denormalize
support via the trait for BC. Symfony and Laravel DI register the
new denormalizers.
@soyuka
deprecation path
9df0a0c
@soyuka @claude
fix(jsonapi): restore getSupportedTypes override in ItemNormalizer
6772b9e 
The normalizer/denormalizer split accidentally dropped this override.
Without it, JsonApi\Serializer\ItemNormalizer inherits the parent's
generic implementation (returns ['object' => false] for any format),
which breaks Symfony Serializer fast-path routing — a more generic
normalizer can win for formats that should land on the JSON:API one.

Restored to the same shape kept by JsonLd\Serializer\ItemNormalizer
post-split, matching the pre-split behavior.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@soyuka
feat(toon): toon encoder component
6b0c9f7
@soyuka
okay
2909b58
soyuka added a commit to soyuka/core that referenced this pull request May 6, 2026
@soyuka
refactor: split normalizer/denormalizer
8a92c81 
| Q             | A
| ------------- | ---
| Branch?       | main
| Tickets       | prerequisite for api-platform#7710
| License       | MIT
| Doc PR        | ∅

Extract a dedicated ItemDenormalizer alongside each ItemNormalizer
(generic Serializer, JSON-LD, JSON:API) with shared logic in an
ItemNormalizerTrait. Existing normalizers keep their denormalize
support via the trait for BC. Symfony and Laravel DI register the
new denormalizers.
soyuka added a commit to soyuka/core that referenced this pull request May 6, 2026
@soyuka
refactor: split normalizer/denormalizer
da8fa9a 
| Q             | A
| ------------- | ---
| Branch?       | main
| Tickets       | prerequisite for api-platform#7710
| License       | MIT
| Doc PR        | ∅

Extract a dedicated ItemDenormalizer alongside each ItemNormalizer
(generic Serializer, JSON-LD, JSON:API) with shared logic in an
ItemNormalizerTrait. Existing normalizers keep their denormalize
support via the trait for BC. Symfony and Laravel DI register the
new denormalizers.
@soyuka

soyuka commented Sep 23, 2026

Copy link
Copy Markdown
Member Author

Closing this.

TOON does not have a registered media type. This branch configures application/x-toon, while the encoder's own comments name text/ld+toon, text/hal+toon and text/vnd.api+toon. It also pulls a third-party runtime dependency for a specification that lives in a community repository and is aimed at prompt token economics rather than HTTP payloads.

The stronger reason is the shape. ToonEncoder documents TOON as an encoding format usable with any representation, yet the component ships seven representation-specific normalizers, one per existing hypermedia format. That is a variant per format and it says the format is being attached at the wrong layer.

None of this needs to live in core. An application can register its own encoder service and add the format to api_platform.formats today, with no change here.

The ItemNormalizer and ItemDenormalizer trait extraction that rode along with this branch is worth keeping and will come back as its own pull request, judged on its own merits.

Worth revisiting if TOON gets an IANA media type or an implementation in symfony/serializer.

@soyuka soyuka closed this Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@soyuka