You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
sdk publish: no telemetry for publishes that fail after being accepted #313
apimatic sdk publish only reports telemetry when the publishing API rejects the publish request. SdkPublishAction calls onPublishSdkError in exactly one place:
which fires SdkPublishValidationFailedEvent (400/403/404, auth, validation).
Nothing is tracked for the case where the request is accepted and publishing then terminates in Failed, Exception, or InternalError, nor for a getSdkPublishingLog error that ends the poll. The CLI observes these outcomes — it prints them and exits 1 — but never reports them, so the failure rate of publishes that actually reached the publishing service is invisible.
Why it wasn't folded into the existing event
SdkPublishValidationFailedEvent models a rejected publish request, and its message carries a real service error string. A post-acceptance failure has no equivalent message (only per-target eventType values), and routing it through an event named …ValidationFailed would mean that metric silently stops meaning one thing.
Suggested shape
A dedicated event, e.g. SdkPublishFailedEvent extends DomainEvent, with a message summarising which targets failed and with what eventType.
A second callback threaded from commands/sdk/publish.ts through both mode actions into SdkPublishAction, alongside the existing onPublishSdkError.
Decide whether a status-fetch error (outcome unknown) is reported as the same event, a distinct one, or not at all — it is not a publish failure, and conflating it would inflate the failure rate.
Context
Both interactive and non-interactive sdk publish now poll to a terminal state, so both modes reach this untracked failure path. Deliberately left out of the change that added polling to interactive mode, to keep that a behavioral-parity fix. Related: #312.
Activity
fix: poll for publish completion in interactive sdk publish (#315)
chore(release): set `package.json` to 1.3.0-beta.1 [skip ci]
chore(release): set `package.json` to 1.3.0 [skip ci]