Repository navigation
feat: support the base path and the new API prefix in the storage client - #2468
Merged
Merged
Conversation
Storage plugin v3 mounts the routes under the server base path, while v2 always serves them at the server root (see appium/appium#22906). Both versions serve the `/appium/storage` prefix, plugins older than 1.2.0 only the legacy `/storage` one. The client now probes the candidate route roots (base path first, then the server root, for the new prefix and then the legacy one), moving on on 404 only. A route is remembered only after a successful response, so a transient error cannot pin a wrong layout. The web socket paths returned by the plugin are server-root-relative in all versions, so they are now resolved against the server root rather than appended to the base URL path. The URL helper also passed the authority where the user info is expected, which is fixed as well. `StorageClient.PREFIX` now equals `/appium/storage`. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
mykola-mokhnach
requested review from
SrinivasanTarget,
saikrishna321 and
valfirst
as code owners
October 6, 2026 21:58
valfirst
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storage plugin v3 mounts the routes under the server base path, while v2 always serves them at the server root (see appium/appium#22906). Both versions serve the
/appium/storageprefix, plugins older than 1.2.0 only the legacy/storageone.The client now probes the candidate route roots (base path first, then the server root, for the new prefix and then the legacy one), moving on on 404 only. A route is remembered only after a successful response, so a transient error cannot pin a wrong layout.
The web socket paths returned by the plugin are server-root-relative in all versions, so they are now resolved against the server root rather than appended to the base URL path. The URL helper also passed the authority where the user info is expected, which is fixed as well.
StorageClient.PREFIXnow equals/appium/storage.