Repository navigation
Add opt-in CSV value formatting - #101
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
--csv-format=simple|spanner-clifor experimental CSV output. The default remains unchanged; the opt-in format trims NUMERIC trailing zeros and uses bracket-style STRUCT values, including inside arrays.CSV configuration and writers now live together in
csv.go, and streaming reads and committed DML share the same settings. Invalid option combinations fail before opening outputs or creating a client. Existing CSV goldens are unchanged.Addresses the CSV opt-in portion of #40; does not close that issue or add jq/YAML formatters.
Validation: Go 1.25.13
go build ./...,go test ./...including the Docker emulator, targeted CSV tests, and golangci-lint v2.12.2 all passed. Transport tests cover default/explicit simple/compatible formatting for SELECT and DML, zero rows, redaction, and invalid options.