Repository navigation
Replace go-spannulls with spanvalue/gcvctor for typed NULL params - #49
Conversation
STRUCT and ARRAY typed NULLs in PLAN mode now use scalar NULL via gcvctor.NullOf, matching current Spanner behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Code Review
This pull request replaces the github.com/apstndb/go-spannulls dependency with github.com/apstndb/spanvalue/gcvctor. It updates params/params.go to use gcvctor.NullOf for generating null generic column values, cleans up imports, and adjusts a test case in params/params_test.go to expect a null value instead of a list containing a null value. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary
gcvctor.NullOffrom spanvalue for PLAN-mode typed NULL parameters.Test plan
go test ./params/...Made with Cursor