Repository navigation
Replay cached prefix for fresh lazy row views - #83
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After
first(.rows[]), a fresh lazy rows view previously skipped the cached prefix: a three-row result reported length two or returned only rows two and three.Replay cached rows from each view's own position before reading additional rows. Array materialization returns the complete cache, including values already consumed through the same captured view. Add regressions for partial reads, captured views, redaction, and errors after the cached prefix.
Builds on the active-cursor stats-drain fix merged in #82. This PR targets main and contains only the fresh-view replay fix; the broader streaming work in #70 stays open.
Validation: build, package tests, full emulator suite, vet, and golangci-lint with Go 1.25.13 passed locally. Go and lint workflows run on the updated main-targeting PR head.