Skip to content

Allow to provide arguments to Popen using std::vector - #3

Closed
mispecto wants to merge 3 commits into
arun11299:masterfrom
mispecto:master
Closed

mispecto wants to merge 3 commits into
arun11299:masterfrom
mispecto:master

Conversation

@mispecto

Copy link
Copy Markdown

No description provided.

Comment thread subprocess.hpp Outdated
}

template <typename... Args>
Popen(std::vector<std::string> cmd_args, Args&& ...args):vargs_(cmd_args)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal, but I would like cmd_args to be moved into vargs_. Otherwise the change looks good. Thanks for contributing!

@mispecto mispecto closed this Dec 4, 2017
@mispecto

mispecto commented Dec 4, 2017

Copy link
Copy Markdown
Author

Creating a new clean one

@enenH enenH mentioned this pull request Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants