Repository navigation
fix(web): new worktree conversations no longer stay empty - #47
Merged
Merged
Conversation
Skald review statusSkald: review ready (success) at review state version 10, head BlockingNothing is holding this pull request open. ClearedNothing is cleared at this epoch. Blocking: 0. Advisory: 0. Cleared: 0. Fenced: 0. Review rounds
|
There was a problem hiding this comment.
Skald review is clean
Reviewed head ff316fba5d0c64392ca5344f1b9ea87bc2e450dc against base atli (d024685ace8dbbf0adfc75e27e91dcaabd9f368e).
First round
Standing summary: open
Review details
Completed reviewers:
- architecture (hub-dispatch-v2:codex:gpt-6.1-sol:medium:8ef92ce46d3e55c4)
- frontend (hub-dispatch-v2:codex:gpt-6.1-sol:medium:8ef92ce46d3e55c4)
- testing (hub-dispatch-v2:codex:gpt-6.1-sol:medium:8ef92ce46d3e55c4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
New worktree conversations can remain on preparation or show an empty conversation even after the server creates the worktree and the agent replies. The chat lifecycle subscribes to stop status using a local draft’s reserved thread ID; the resulting pre-creation 404 is retained as a definitive missing thread until the client restarts.
Change
Wait for the server thread shell before subscribing to stop status. This fixes the shared web/desktop chat hook; mobile does not use this hook. Worktree creation and provider behavior are unchanged.
Scope and approval
Requested by the fork maintainer. This is a focused correction to an obvious lifecycle bug, with no new feature or setting.
Verification
thread_not_foundbefore thread creation; the same thread subsequently completed workspace preparation and received an assistant reply.vp run check:changed HEADpassed format, lint, knip, affected typechecks, the regression test, and React Compiler checks before rebasing onto currentatli.Implemented with GPT-6 Astra through the Codex harness.