[WIP] Use atom.watchPath instead of PathWatcher

[winstliu]

Requirements

• Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
• All new code requires tests to ensure against regressions

Description of the Change

Replaces pathwatcher with atom.watchPath.

Alternate Designs

None.

Benefits

A better watching library that doesn't lock files everywhere on Windows.

Possible Drawbacks

TODO

Applicable Issues

TODO

[daviwil]

AppVeyor still crashing... Maybe try the @atom/temp package with this change?

[winstliu]

@daviwil not crashing; just specs failing. I haven't started fixing specs yet.

[daviwil]

You're right! My bad :)

[smashwilson]

One thing to be aware of - once tree-view is backed by watchPath(), parts of the emulated "atom" filesystem watcher in core won't work any more, because they use terrible hacks to pull these events from tree-view:

https://github.com/atom/atom/blob/204a5aa6950b44ab767e9beee450203b1e7b550c/src/path-watcher.js#L222-L259

I'm not sure what the best solution is there. We could eliminate the "atom" watcher backend, or we could find another way to emulate those events, or just miss them.

[winstliu]

Closing this as I don't feel like I have the necessary experience yet to make this work.