Skip to content

arrays containing negative numbers not parsed properly #14

Open

Description

@gordonwoodhull

From @gordonwoodhull on February 4, 2014 21:20

The wdcplot parser is not expecting expressions within c(...).

It should parse the values in the ordinary tree way instead of assuming plain string/numeric values.

Copied from original issue: att/dcplot.js#5

Activity

  1. gordonwoodhull commented on Sep 25, 2015

    @gordonwoodhull
    ContributorAuthor

    I think the problem is right here:

                else if(sexp[0]==='c')
                        return sexp.slice(1);
                // else we'll process as expression below

    https://github.com/att/rcloud.dcplot/blame/master/inst/www/wdcplot.js#L232

    No, just always process as expression.

    And here's the possibly-errant commit (1/1/2014), which looks like it was going in the right direction but didn't go far enough: att/rcloud@0eec64f

    Extensive changes to expression processing on JS side - needs further testing, but far more robust in principle.

    Har, har.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions