Repository navigation
feat: --response-batch-size for batched LookupResources - #729
Merged
Merged
Conversation
…p-resources - Bump WASM job go-version to 1.27.4 to match the go.mod toolchain required by authzed-go v1.11.1-0.20261120130125-380614b108c9. - Regenerate docs/zed.md for the new --response-batch-size flag. - Bump go.opentelemetry.io/otel/sdk to v1.47.0 to resolve CVE-2026-128085 pulled in by the authzed-go dependency bump. - Register the response-batch-size flag in the lookup-resources test command helper so MustGetUint32 no longer panics.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
vroldanbet
reviewed
Nov 20, 2026
vroldanbet
approved these changes
Nov 20, 2026
Comment on lines
+182
to
+185
| // Request batching against a server that does not support it (this test | ||
| // server is an older SpiceDB that ignores optional_response_batch_size and | ||
| // replies with the singular one-resource-per-message shape). zed must fall | ||
| // back to reading the singular field and still return every resource. |
Contributor
There was a problem hiding this comment.
I guess the locked SpiceDB version may change at any time, compromising this test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
--response-batch-sizeflag tozed permission lookup-resources. When> 0, the client requests the batched LookupResources API (optional_response_batch_size) and decodes the batched response — aLookupResourcesBatchcarrying multiple resources with a single resume cursor per batch.0(default) preserves one-resource-per-message behavior.Why
Lets
zedexercise and benchmark batched LookupResources, which cuts per-message gRPC overhead and cursor-token payload on high-cardinality lookups.Dependency chain
authzed/api#176— proto (merged)authzed/authzed-go#436— regenerated client (merged); pinned here at380614b(bumps zed'sauthzed-gov1.9.0 → the batched client)authzed/spicedb#3517— server side (open)Testing
go build ./...passes against the pinned client.