Repository navigation
feat: lower readImage default maxDimension to 3000px - #1450
Merged
Merged
Conversation
Expose image.maxDimension in config.yaml (already read by readImage) and change the default cap from 5000 to 3000 px. Updates the schema default, the readImage fallback constant, the tool description, and the downscale test to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Expose
image.maxDimensionin config.yaml (already read byreadImage) and change the default cap from 5000 to 3000 px. Updates the schema default, thereadImagefallback constant, the tool description, and the downscale test to match.Type of Change
Testing
Ran
node --testontests/unit/tools/image/readImage.test.jsandtests/unit/config/schemas/image.test.js— 7 tests pass. VerifiedConfigSchema.safeParseagainst the updated config.yaml resolvesimage.maxDimension: 3000.oxlintclean on changed files.Coverage
Checklist
npm run lintpasses