Repository navigation
fix: clear message bubble streaming status when new segment arrives - #1456
Merged
Merged
Conversation
OpenSpec change for issue #1454. Ensures the streaming flag on a prior assistant bubble is cleared when a subsequent message segment arrives, and adds a defensive spinner guard in MessageBubble rendering.
Implements the fix for issue #1454. When a new message segment is added after an assistant message, clear any stale streaming flag on the prior assistant bubble so the spinner stops. Adds a defensive guard in MessageBubble so a bubble with content/segments never renders a spinner. - src/tui/messageList.js: clear stale streaming on prior assistant messages in addMessage - src/tui/messageBubble.js: document defensive pendingState guard - tests: add regression tests for both behaviors
Archives the OpenSpec change and syncs the updated specs for component-message-bubbles and tui-streaming.
Owner
Author
Audit Results — fix-message-bubble-streaming-status (Implementation Audit)Goal Fulfillment
Spec Compliance
Task Completion
Quality Check
Decision
|
6 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #1454: a message bubble's streaming status is not cleared when a new message segment arrives after it. A pending AI message interrupted by a system message still shows a spinner erroneously. This change ensures the
streamingflag on a prior assistant bubble is cleared when a subsequent message segment arrives, and adds a defensive spinner guard inMessageBubblerendering.Type of Change
Testing
npm run test: 4206 tests pass, 0 fail.npm run lint: 0 warnings, 0 errors.npm run coverage: 91.48% overall line coverage maintained.tests/unit/tui/messageList.test.js(addMessage clears stale streaming on a prior assistant message) andtests/unit/tui/messageBubble.test.js(no spinner when a bubble has content/segments despite a stalestreaming: true).Coverage
Checklist
npm run lintpassesCloses #1454