Repository navigation
Fix a number of instrumentation issues that occur when other projects use the fuzzing rules. - #91
Merged
Merged
Conversation
stefanbucur
commented
Dec 6, 2020
Collaborator
- The build flags need to be referenced with the absolute workspace name, so the names resolve correctly when imported in a different repo.
- The fuzzing build mode is now optional so it can be disabled in the projects that wish so.
…e top-level fuzz test is instrumented. Without this change, any other binary that may be built on the transitive dependency chain will also get linked with libFuzzer, resulting in a linker error (duplicate main functions).
* The build flags need to be referenced with the absolute workspace name, so the names resolve correctly when imported in a different repo. * The fuzzing build mode is now optional so it can be disabled in the projects that wish so.
stefanbucur
requested review from
asraa,
inferno-chromium,
markus-kusano and
oliverchang
as code owners
December 6, 2020 23:53
oliverchang
approved these changes
Dec 7, 2020
chabiraabdelaziz
approved these changes
Dec 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.