Repository navigation
Conversation
The public flag already describes when the proxy must load the rules_cc implementations. Use it so the proxy does not duplicate the prerelease version boundary or import private version helpers.
fmeum
approved these changes
Oct 25, 2026
trybka
self-requested a review
October 29, 2026 17:26
trybka
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compatibility proxy switches from native C++ rules to their rules_cc implementations at the same prerelease boundary as
bazel_features.cc.cc_common_is_in_rules_cc. Use that public flag so the proxy no longer repeats the version or imports a private helper.Prepared with Codex.