Skip to content

test(finalizer): cover selected plan finalization semantics - #94

Open
reez wants to merge 1 commit into
bitcoindevkit:masterfrom
reez:selectedplan
Open

reez wants to merge 1 commit into
bitcoindevkit:masterfrom
reez:selectedplan

Conversation

@reez

@reez reez commented Oct 30, 2026

Copy link
Copy Markdown

Description

When I was investigating the external signing and restart workflow in #83 I found that an A-selected Finalizer rejects B+C-only signatures on an unfinalized input but accepts that input if it has already been finalized through B+C.

And existing tests didn’t cover this distinction so this PR adds tests and documentation to clarify when the selected Plan is enforced and protect that behavior against unintended changes (it verifies both spending paths signatures and covers output metadata preservation and clearing)

Notes to the reviewers

Changelog notice

Before submitting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant