Repository navigation
Conversation
reez
marked this pull request as ready for review
November 5, 2026 22:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When I was investigating the external signing and restart workflow in #83 I found that an A-selected Finalizer rejects B+C-only signatures on an unfinalized input but accepts that input if it has already been finalized through B+C.
And existing tests didn’t cover this distinction so this PR adds tests and documentation to clarify when the selected Plan is enforced and protect that behavior against unintended changes (it verifies both spending paths signatures and covers output metadata preservation and clearing)
Notes to the reviewers
Changelog notice
Before submitting