Skip to content

storybook build fails on every PR: Could not detect Solid version #48

Closed

Description

@A-x6

The storybook build check fails on every recent run on dev and on all open PRs with:

Error: Could not detect Solid version: `solid-js` is not installed.
    at resolveSolidVersion (storybook-solidjs-vite/dist/chunk-UXSWORPC.js:10:11)

Root cause: storybook-solidjs-vite detects the Solid major version via storybook's package-manager helpers (getInstalledVersion, then a getAllDependencies() fallback that reads the dependency specifier from package.json and runs it through semver.coerce). packages/storybook/package.json declares "solid-js": "catalog:", and coerce("catalog:") yields nothing, so detection throws before the build even starts. The framework offers no option to pass the Solid version explicitly.

Fix: pin solid-js to the concrete catalog version (1.9.10) in packages/storybook/package.json. Same resolved version and the solid-js@1.9.10 patch still applies; only the specifier string changes.

Secondary issue uncovered once detection passes: the build exceeds node's default old-space heap and dies with FATAL ERROR: Ineffective mark-compacts near heap limit, so the workflow also needs a raised --max-old-space-size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions