Skip to content

fix #3508 - recheck min client count during idle callback - #3509

Merged
brianc merged 1 commit into
brianc:masterfrom
barryhagan:master
Jul 10, 2025
Merged

brianc merged 1 commit into
brianc:masterfrom
barryhagan:master

Conversation

@barryhagan

Copy link
Copy Markdown
Contributor

No description provided.

@brianc

brianc commented Jul 10, 2025

Copy link
Copy Markdown
Owner

wow! amazing turn around on this! thank you! ❤️

@brianc

brianc commented Jul 10, 2025

Copy link
Copy Markdown
Owner

unrelated side note: I should port the test to use async/await now that it exists instead of using co. I used co because way way back async/await wasn't a thing, but writing callbacks was always icky.

@brianc
brianc merged commit 01fadd9 into brianc:master Jul 10, 2025
@sehrope

sehrope commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

I used co because way way back async/await wasn't a thing, but writing callbacks was always icky.

Async / await?! Ha, we didn't even have native Promises!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants