Repository navigation
fix(release): publish the major version tag to ghcr.io - #361
Merged
Merged
Conversation
The ghcr.io metadata had {{version}}, {{major}}.{{minor}} and latest but no {{major}}, so v2 images were never tagged :2 (v1 had :1). Docker Hub already gets it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #344
The ghcr.io image tags in
.github/workflows/release.ymlhad{{version}},{{major}}.{{minor}}andlatest, but no{{major}}. So v2 images were never taggedghcr.io/buggregator/server:2, while v1 had:1. The Docker Hub block already publishes the major tag; this adds the same line to the ghcr.io block. Nothing else changes.After the next release
docker pull ghcr.io/buggregator/server:2works.