Repository navigation
Keep artifact downloads streaming in debug mode - #1057
Merged
Merged
Conversation
Omit artifact response bodies from debug output, including redirect responses, while retaining HTTP metadata and ordinary API diagnostics. Cover streaming, payload integrity and bounded debug output with a synthetic HTTP download test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With
--debug, artifact downloads currently buffer and log the entire response before writing it to disk. Large artifacts therefore require payload-sized debug logs and extra memory instead of streaming to their destination.Omit artifact response bodies from debug output, including redirects and regardless of content type. Keep HTTP metadata and ordinary API body diagnostics with their existing redaction. A local synthetic download test checks that data reaches disk before the full response arrives, preserves the payload bytes, and keeps debug output bounded.
Testing
go test ./..., with ambient API credentials unset)gofumpt)golangci-lintreports no issues