Skip to content

Keep artifact downloads streaming in debug mode - #1057

Merged
mcncl merged 1 commit into
mainfrom
fix/debug_artifact_streaming
Oct 21, 2026
Merged

mcncl merged 1 commit into
mainfrom
fix/debug_artifact_streaming

Conversation

@mcncl

@mcncl mcncl commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Description

With --debug, artifact downloads currently buffer and log the entire response before writing it to disk. Large artifacts therefore require payload-sized debug logs and extra memory instead of streaming to their destination.

Omit artifact response bodies from debug output, including redirects and regardless of content type. Keep HTTP metadata and ordinary API body diagnostics with their existing redaction. A local synthetic download test checks that data reaches disk before the full response arrives, preserves the payload bytes, and keeps debug output bounded.

Testing

  • Tests have run locally (go test ./..., with ambient API credentials unset)
  • Code is formatted (gofumpt)
  • Race tests pass for the factory, artifact helper, and download-command packages
  • golangci-lint reports no issues

Omit artifact response bodies from debug output, including redirect
responses, while retaining HTTP metadata and ordinary API diagnostics.

Cover streaming, payload integrity and bounded debug output with a
synthetic HTTP download test.
@mcncl
mcncl requested review from a team as code owners October 21, 2026 03:25
@mcncl
mcncl enabled auto-merge (squash) October 21, 2026 03:27
@mcncl
mcncl merged commit 52aec7a into main Oct 21, 2026
2 checks passed
@mcncl
mcncl deleted the fix/debug_artifact_streaming branch October 21, 2026 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant