Skip to content

Unify global debug and verbose diagnostics - #1059

Merged
mcncl merged 3 commits into
mainfrom
feat/unify_debug_verbose
Oct 21, 2026
Merged

mcncl merged 3 commits into
mainfrom
feat/unify_debug_verbose

Conversation

@mcncl

@mcncl mcncl commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Description

bk api --debug logs HTTP requests and responses but omits rate-limit retry warnings, while bk api --verbose only reports those retries. One diagnostic setting makes troubleshooting more predictable.

--verbose is now a global alias of --debug, intentionally available on all commands. Both bk api /pipelines --debug and bk api /pipelines --verbose emit HTTP diagnostics and one warning per retry. This broadens the old API verbose output to include HTTP diagnostics, with the existing redaction rules unchanged.

Changes

  • Remove the API-specific verbose flag and use the global debug setting for retry warnings.
  • Document the alias and unified output in help.
  • Cover global alias parsing, silent default retries, warning counts, JSON stdout, diagnostic stderr, and token redaction.

Testing

  • Tests have run locally (env -u BUILDKITE_API_TOKEN mise run test)
  • Code is formatted (mise run format)
  • mise run lint: 0 issues

Make verbose an alias of debug across commands and include API rate-limit
retry warnings in the same diagnostic mode. Preserve HTTP redaction and
keep JSON results separate from diagnostic output.

Amp-Thread-ID: https://ampcode.com/threads/T-733d2080-0363-428a-96cf-bcfafb8490c8
@mcncl
mcncl requested review from a team as code owners October 21, 2026 04:17
buildsworth-bk-app[bot]
buildsworth-bk-app Bot previously approved these changes Oct 21, 2026
@mcncl
mcncl enabled auto-merge (squash) October 21, 2026 04:18
@buildsworth-bk-app
buildsworth-bk-app Bot dismissed their stale review October 21, 2026 04:23

Superseded by a newer Buildsworth review.

@buildsworth-bk-app buildsworth-bk-app Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One blocker: the global --verbose alias is missing in this revision.

Want to dig deeper?

Paste this into your agent to explore the findings from this review's Buildkite build:

Download the buildsworth logs from build 43346, then answer my questions about the findings.

Install the reading-buildsworth-logs skill to run this.

Comment thread cmd/api/api.go Resolved
Keep the HTTP diagnostic security warning while restoring the verbose
spelling of debug. Existing alias tests reproduce the missing flag and
pass again with this tag restored.

Amp-Thread-ID: https://ampcode.com/threads/T-733d2080-0363-428a-96cf-bcfafb8490c8

@buildsworth-bk-app buildsworth-bk-app Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The earlier blocker is resolved; no new findings.

Want to dig deeper?

Paste this into your agent to explore the findings from this review's Buildkite build:

Download the buildsworth logs from build 43355, then answer my questions about the findings.

Install the reading-buildsworth-logs skill to run this.

@buildsworth-bk-app
buildsworth-bk-app Bot dismissed their stale review October 21, 2026 04:27

Superseded by a newer Buildsworth review.

@mcncl
mcncl merged commit 95a8fe4 into main Oct 21, 2026
2 checks passed
@mcncl
mcncl deleted the feat/unify_debug_verbose branch October 21, 2026 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant