You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A concrete case where the build-time manifest rewrite this PR removes causes trouble, in case it helps to get it merged.
android/build.gradle rewrites src/main/AndroidManifest.xml inside node_modules on every Gradle configuration (with AGP 7+ it strips package=). @react-native-masked-view/masked-view 0.3.2 is a dependency of expo-router, and Expo's fingerprint (runtimeVersion: { policy: 'fingerprint' }) hashes that file. So any local expo run:android changes the project fingerprint: the local runtime stops matching the one on EAS and on the store build, and OTA updates published from that checkout target a runtime no installed build has. We hit it twice before tracking it down; the workaround was npm ci before every fingerprint check.
We now ship the same idea as this PR as a local patch on 0.3.2: the manifest without package= (what the script left anyway on AGP 8) and namespace declared unconditionally, since React Native 0.73+ requires AGP 8. The merged manifest is identical, and building no longer modifies node_modules.
Would be great to see this (or just dropping the rewrite for AGP ≥ 7.3) in a release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
On Prev-PR, we used script to change AndroidManifest content.
Now we create new AndroidManifest file, then use this when android support namespace
Test Plan