Repository navigation
fix(repack): run build steps serially to avoid wiping declarations - #1496
Merged
Merged
Conversation
build:js and build:ts ran in parallel, and babel's --delete-dir-on-start could wipe declaration files tsc had already written when babel started slowly (e.g. under turbo load), breaking dependent package builds with TS7016. Run them one after the other; tsc dominates the build time, so this costs roughly a second or two on a cold build.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/repackranbuild:js(Babel with--delete-dir-on-start) andbuild:ts(tsc --emitDeclarationOnly) in parallel. If Babel started slowly, for example while turbo was building other packages, its delete could land aftertschad already written some.d.tsfiles. Dependent packages then failed withTS7016: Could not find a declaration file for module '@callstack/repack'(seen inrepack-expoandplugin-reanimated).The two steps now run one after the other.
tsctakes most of the build time, so running Babel alongside it saved little. Measured on a cold build: ~1.7s in parallel vs ~3.4s serially, and turbo caches the result.Test plan
pnpm turbo run build --forcepasses withpackages/repack/dist/index.d.tspresent