Fix native FormData uploads in Node - #9
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node's native FormData is currently passed to cross-fetch's node-fetch v2 transport, which sends the literal text [object FormData] with text/plain content type. This prevents uploadAppData from delivering the sourceFile archive.
Pair native FormData with the runtime's native fetch encoder. Keep the existing cross-fetch path for JSON and other form-data implementations. Authentication and response/error handling are unchanged.
Adds a local HTTP-server regression test verifying multipart content type, sourceFile name, filename, authentication header, attached endpoint, and exact binary payload bytes.
Validation: reproduced the text/plain failure with published caprover-api 0.0.21; npm test passed all 11 tests after the fix, including build/lint and the real transport regression. Formatting and diff checks passed.
Prerequisite for the caprover-e2e source-upload suite (plan PR6). Publish a version containing this fix and update that suite's dependency before merging/running it. This PR does not publish a package.