Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
box_dots=True, a valid path through a BoxList can be read withbox["a[0].b"], but membership returns False andbox.get("a[0].b", sentinel)returns the sentinel. This also affects a terminal index such asa[0].Resolve these paths without invoking default-box creation. Keep literal-key precedence, existing dot exclusion rules, nested configuration, intact-container lookup limits, and ordinary BoxList value membership. Add regression tests, including a missing/default path and an oversized index, plus the required changelog and contributor entry.
Validation:
The installed-wheel checks also reproduce an existing Cython 3.3 TypeError when initializing nested boxes with
box_dots_exclude: the exact develop base produces the same error. This is recorded as a baseline constructor limitation, not a passing constructor test.AI-assisted implementation and validation with Codex.