Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

As a user of opencensus-cpp, I'd want dependent library locked to specific version #250

Closed

Description

@StevenYCChou

Currently, opencensus-cpp uses multiple upstream libraries, including abseil, gmock, gtest, prometheus-cpp. However, when we pulled in these dependent libraries, we pulled off from master. As a user of opencensus-cpp, if I want to build opencensus-cpp library from scratch, I may get different result from time to time.

Therefore, I suggest locking down the version for both bazel and CMake for each opencensus-cpp release.

for bazel, an example is the Bazel's absl dependent:
from

    urls = ["https://github.com/abseil/abseil-cpp/archive/master.zip"],

to

    urls = ["https://github.com/abseil/abseil-cpp/archive/20180600.zip"],

for Cmake's absl dependent, from

	GIT_TAG "master"

to

	GIT_TAG "20180600"

Activity

  1. g-easy commented on Dec 5, 2018

    @g-easy
    Contributor

    This issue is related to #130

    Now that we're moving to releases with branches (#185) maybe we should pin dependencies for releases. As per #130, I'd still like to build from HEAD on the opencensus-cpp master branch.

  2. g-easy commented on Feb 7, 2019

    @g-easy
    Contributor

    Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions