Conversation
…#3504 Signed-off-by: Pratyksh Gupta <pratykshgupta9999@gmail.com> Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
…rsion of the code Signed-off-by: Adrian Edwards <adredwar@redhat.com>
| import ast | ||
| import os | ||
| import tempfile | ||
| import pytest |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0611: Unused import pytest (unused-import)
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR was ported from augurlabs/augur#3514 filed by @guptapratykshh because the contribution was deemed to still be useful.
Description
augur/util/inspect_without_import.pywith theastmodule to robustly extract phase function names fromstart_tasks.py.tests/test_util/test_inspect_without_import.pyto verify the fix and ensure it handles various edge cases (indentation, decorators, multi-line definitions).This PR fixes #161
Notes for Reviewers
Signed commits