Conversation
Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com> Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Contributor
Author
|
This PR was fairly substantially changed from its original form to account for changes made in #311 It is clean as far as naming is concerned, should just need testing (any failures of which are on me since i wrote the code in the merge editor while rebasing) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR was ported from augurlabs/augur#3549 filed by @guptapratykshh because the contribution was deemed to still be useful.
Description
I have changed how the configuration file path is resolved to match the new config directory standards. Instead of using separate CONFIG_LOCATION variable, the system now builds the path using CONFIG_DATADIR. This simplifies docker-compose.yml file by getting rid of unnecessary variables while maintaining backward compatibility.
This PR fixes #166
Notes for Reviewers
Signed commits