Skip to content

Fix: applyStack() returned the sum of all values for hidden dataset indices - #11834

Closed
rluba wants to merge 1 commit into
chartjs:masterfrom
FabmanHQ:fix/hiding_stacked_datasets_animation
Closed

rluba wants to merge 1 commit into
chartjs:masterfrom
FabmanHQ:fix/hiding_stacked_datasets_animation

Conversation

@rluba

@rluba rluba commented Jul 15, 2024 •

Copy link
Copy Markdown

… which causes incorrect animations when showing/hiding stacked datasets. This fixes #11198.

@etimberg

Copy link
Copy Markdown
Member

Is it possible to write a test for this change?

@DeyLak

DeyLak commented Oct 23, 2024

Copy link
Copy Markdown
Contributor

That is exactly the fix I'm desperate for. Would be great, if this got merged.

@etimberg I could've looked into writing the test, but I'm new to the library codebase, so I would really appreciate, if you can help me to find the correct place to write this test.
I found tests for datasets visibility in the core.controller.tests.js, but I didn't find lots of examples of how and where to write tests of animated transitions. Is there now a standart way to test transitions and to check which values library are using during the transition?

@etimberg

Copy link
Copy Markdown
Member

@DeyLak I don't believe we have a standard way to check for values during animations.

I would probably write a test that verifies that the sum doesn't include hidden datasets and that should be enough.

@DeyLak

DeyLak commented Oct 24, 2024

Copy link
Copy Markdown
Contributor

I've submitted the new PR: #11938

@etimberg

Copy link
Copy Markdown
Member

Closing since this was fixed in #11938

@etimberg etimberg closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stacked Bar Chart show/hide animations have wrong target values

3 participants