Conversation
`if (!document)` throws a ReferenceError when document is undeclared, which is the server case the guard exists for, so load() rejected and unload() threw instead of returning. defaultDocument from utils/browser is undefined on the server. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Both SSR guards in
useScriptTagreadif (!document), commented "SSR Support". On the serverdocumentis undeclared, so evaluating it throws before the!applies:defaultDocumentfromutils/browseris the existingtypeof-based guard, so both sites use that.Found by rendering every exported hook with
renderToStringunder@jest-environment nodeand calling each function it returns, the same shape as the existinguseOrientation/index.ssr.spec.tsx. The newindex.ssr.spec.tsxfollows that file. Reverting either guard on its own fails it.Type of Change
Checklist
Unticked: documentation (no API change), and the "read and understood every line myself" box, which is @rawsun007's to tick rather than mine. Written with Claude Code (Claude Opus 5.5) on his account; he answers review comments himself.
The same sweep also flagged four other hooks whose returned functions touch a browser global on the server.
useRafState's setter callscancelAnimationFrameunguarded.useCookie,useRafFnanduseScrollIntoViewdo too, but all three are in #205, so I have left them alone.pnpm jestinpackages/core: 432 passing across 75 suites.pnpm lintclean.🤖 Generated with Claude Code