Replace from_string with make_address in documentation examples. - #1773
Open
dornbirndevelops wants to merge 1 commit into
Open
dornbirndevelops wants to merge 1 commit into
dornbirndevelops wants to merge 1 commit into
Conversation
The ip::address::from_string and ip::address_v4::from_string functions were deprecated in favour of make_address and make_address_v4, and removed in asio 1.34.0. Several code snippets still used them, so the examples no longer compile as written. Update those snippets to the current free functions. No library code is affected.
Author
|
Should the usages in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ip::address::from_stringandip::address_v4::from_stringfunctions were deprecated in favour ofmake_addressandmake_address_v4, and removed in asio 1.34.0.Several code snippets still used them, so the examples no longer compile as written.
Update those snippets to the current free functions. No library code is affected.