Skip to content

Installation repositories event does not pull in some data #1117

Closed

Description

@joshsmith

Problem

When we receive the installation_repositories event, we are unfortunately not pulling in some data about the repository, including:

  • github_account_id
  • github_account_login
  • github_account_avatar_url
  • github_account_type

This data is available in the installation's account object.

I'm wondering if we should simply defer to the installation's data on this and instead remove the github_account_ details from the repos themselves.

Activity

  1. begedin commented on Oct 30, 2017

    @begedin
    Contributor

    Correct me if I'm wrong, but we don't actually use the account data from the repo anywhere. On ember, we render the installation data, next to the installation, but the repos are relatively simple list items in comparison.

    I guess if we sync project with repos across multiple installations, we will then have to render these icons next to the repo itself on other pages (the task page, for example), but that should not be a huge deal.

    I would be ok with ditching these fields and relying on installation fields instead.

    I would put an estimate at ~1 hour to remove them from the API and potentially another 0.5-1 hour to clean it up on ember (depending on us just needing to remove the fields from the model or having to do slightly more).

    What do you think @joshsmith ?

  2. joshsmith commented on Oct 30, 2017

    @joshsmith
    ContributorAuthor

    This data is actually used for presenting the details of it, which is how it was discovered.

  3. self-assigned this
    on Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions