You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Installation repositories event does not pull in some data #1117
Correct me if I'm wrong, but we don't actually use the account data from the repo anywhere. On ember, we render the installation data, next to the installation, but the repos are relatively simple list items in comparison.
I guess if we sync project with repos across multiple installations, we will then have to render these icons next to the repo itself on other pages (the task page, for example), but that should not be a huge deal.
I would be ok with ditching these fields and relying on installation fields instead.
I would put an estimate at ~1 hour to remove them from the API and potentially another 0.5-1 hour to clean it up on ember (depending on us just needing to remove the fields from the model or having to do slightly more).
Activity
begedin commentedon Oct 30, 2017
Correct me if I'm wrong, but we don't actually use the account data from the repo anywhere. On ember, we render the installation data, next to the installation, but the repos are relatively simple list items in comparison.
I guess if we sync project with repos across multiple installations, we will then have to render these icons next to the repo itself on other pages (the task page, for example), but that should not be a huge deal.
I would be ok with ditching these fields and relying on installation fields instead.
I would put an estimate at ~1 hour to remove them from the API and potentially another 0.5-1 hour to clean it up on ember (depending on us just needing to remove the fields from the model or having to do slightly more).
What do you think @joshsmith ?
joshsmith commentedon Oct 30, 2017
This data is actually used for presenting the details of it, which is how it was discovered.