[pull] main from react:main - #671
Merged
Merged
Conversation
Backports oxc-project/oxc#26451 to the Rust React Compiler. Check component parameters before scanning for hooks or JSX, so functions with invalid component signatures skip the traversal. Component classification stays the same. Co-authored-by: Codex <noreply@openai.com>
…37576) ## Summary `react-hooks/purity` already reports `Date.now()` during render, but not `new Date()` / `new Date().getTime()` / `new Date().getFullYear()`. Those also read the current clock. React's purity docs list `new Date()` next to `Date.now()`. Zero-argument `new Date()` is now treated as an impure call (same diagnostic as `Date.now()`). Constructing from an explicit timestamp stays allowed: `new Date(timestamp)`. Fixes #37553 ## How did you test this change? - `yarn snap --pattern "**/*new-date*"` (4 fixtures passed) - `yarn workspace eslint-plugin-react-compiler test -- ImpureFunctionCallsRule` (4 tests passed) Made with [Cursor](https://cursor.com) --------- Co-authored-by: Pieter De Baets <pieter.debaets@gmail.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )