Repository navigation
Conversation
Three SBA nodes behind nginx with self-registering clients, Mailpit and scenario switches to reproduce codecentric/spring-boot-admin#2795, #4773, #5743 and to try PRs #5266, #5726, #5739.
Add filtering-bean notifier variant (avoids filteringNotifier/compositeNotifier cycle), sent-notifications-disabled and hazelcast-disabled scenarios, and document results against the PR build.
Contributor
Author
|
Tested codecentric/spring-boot-admin#5739 (head
|
SPRING_AOT_ENABLED does not enable AOT. Retested PR 5739 with real AOT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
hazelcast/example to reproduce Hazelcast clustering issues and to try out open PRs.Setup
:8080)/pollers, viaX-SBA-Nodeheader):8026) to see which node sent a notification/actuator/playgroundper node: cluster members, event store, notification trigger, notifiers, map sizes./run.sh <scenario>; combine several withdocker compose --env-file a.env --env-file b.env up -d --force-recreate./inspect.sh,./redeploy.sh [--kill]SBA_VERSION=<version> ./buildAndRunAll.shbuilds against a locally installed SBA (e.g. a PR branch, installed with-Drevision=...to keep other snapshots untouched)Scenarios and results
defaultvsnotifier-beanNotificationTrigger, 3 mails;@Beannotifier →HazelcastNotificationTrigger, 1 mail. Tested PR head4c5b3eed6: 1 mail in all scenarios (properties,@Bean, userFilteringNotifier, AOT, node restart), no startup cycledefault,event-store-ttl+./redeploy.sh--killleaves the old instance OFFLINE on all nodesin-memory-event-storeshardingselective-caches,sent-notifications-disabled,hazelcast-disabled,aotcf35dd37b, see belowendpoint-cachecodecentric/spring-boot-admin#5739 (PR build
cf35dd37b)defaultNotificationTriggerselective-cachesNotificationTriggerhazelcast-disabledNotificationTriggernotifier-beannotifier-filtering-beanHazelcastNotificationTriggersent-notifications-disabledNotificationTriggerselective-caches+notifier-filtering-beanHazelcastNotificationTrigger*-enabledflags work at runtime. (An earlier AOT claim here was wrong:SPRING_AOT_ENABLEDdoes not enable AOT. Use-Dspring.aot.enabled=trueand look forStarting AOT-processed.)MailNotifier@Beanfails withfilteringNotifier -> compositeNotifier -> filteringNotifier(comes from #5737, fixed by #5726), also withnotification-filters-enabled=false.notifier-filtering-beanavoids it with a user defined@Primary FilteringNotifier.codecentric/spring-boot-admin#5739 after the force push (
da1b8914c)Conflict free, tests pass, but
@ConditionalOnPropertyonsentNotificationsMap/notificationFiltersMapis evaluated at build time: with real AOT,sent-notifications-enabled=falseis ignored (HazelcastNotificationTriggerstill used). Without AOT it works.codecentric/spring-boot-admin#5739 rebased on master with #5726 (local rebase
921fedef1)selective-caches(local event store, Hazelcast sent-notifications) now givesHazelcastNotificationTriggerand 1 mail, also with property notifiers and with real AOT. This is the setup requested in #4773.sent-notifications-disabled: plainNotificationTrigger, every node notifies.notification-filters-enabled=false:notificationFiltersMapis a local map.FilteringNotifierno longer exists, so the PR's test for the filters flag had to change.codecentric/spring-boot-admin#5726 (PR build
4c5b3eed6)default,notifier-bean,notifier-filtering-bean:HazelcastNotificationTriggeron all nodes, 1 mail per status change. Also 1 mail after restarting a node.AdminServerHazelcastAutoConfiguration, so merge #5726 first and rebase #5739.Notes
@ConditionalOnProperty(evaluated at build time under AOT). Theaotscenario re-enables it.AbstractStatusChangeNotifier(#5716), #5266 results.