Skip to content

adding option --edge to install latest edge / preview version - #4605

Merged
jsjoeio merged 2 commits into
coder:mainfrom
Leask:main
Dec 14, 2021
Merged

jsjoeio merged 2 commits into
coder:mainfrom
Leask:main

Conversation

@Leask

@Leask Leask commented Dec 11, 2021

Copy link
Copy Markdown
Contributor

Adding option --edge to install latest edge / preview version.

$ ./install.sh --edge true
$ ./install.sh --edge=true

@Leask
Leask requested a review from a team as a code owner December 11, 2021 02:31

@code-asher code-asher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fantastic idea!

Comment thread install.sh Outdated
--version X.X.X
Install a specific version instead of the latest.

--edge [true | false (default) ]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we leave off the value and set this to true when the flag is set? This is how we have been handling booleans, for example see --dry-run.

@jsjoeio jsjoeio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fantastic idea! I agree with @code-asher's feedback. Let's mimic how --dry-run is used. If flag passed, set to true else false.

@codecov

codecov Bot commented Dec 13, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #4605 (6edb195) into main (c77999b) will not change coverage.
The diff coverage is n/a.

❗ Current head 6edb195 differs from pull request most recent head 746f55a. Consider uploading reports for the commit 746f55a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4605   +/-   ##
=======================================
  Coverage   66.14%   66.14%           
=======================================
  Files          30       30           
  Lines        1654     1654           
  Branches      331      331           
=======================================
  Hits         1094     1094           
  Misses        475      475           
  Partials       85       85           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c77999b...746f55a. Read the comment docs.

@Leask

Leask commented Dec 13, 2021

Copy link
Copy Markdown
Contributor Author

Adding this commit: updated arg --edge parsing to match the style of --dryrun
746f55a
Thanks for the review :)

@Leask
Leask requested a review from code-asher December 14, 2021 03:19

@jsjoeio jsjoeio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! Thanks so much

@jsjoeio

jsjoeio commented Dec 14, 2021

Copy link
Copy Markdown
Contributor

(You can ignore Docs preview - I need to fix it)

@Leask

Leask commented Dec 14, 2021

Copy link
Copy Markdown
Contributor Author

Thanks!

@jsjoeio
jsjoeio dismissed code-asher’s stale review December 14, 2021 22:30

Changes requested were made

@jsjoeio
jsjoeio merged commit 18e66c4 into coder:main Dec 14, 2021
@jsjoeio jsjoeio added this to the 4.0.0 milestone Dec 14, 2021
@Leask

Leask commented Dec 14, 2021

Copy link
Copy Markdown
Contributor Author

🆒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants