The Codex Comments check (scripts/check_codex_comments.sh) fails when the Codex Review Summary card lists a finding, even after that finding's review thread is resolved.
Seen on #89 (head 13066a2): all review threads were resolved, and the latest Codex code and security reviews were clean. The check still failed with "1 unminimized regular comment from bot". The comment was the summary card: it now has a findings section that links to the resolved thread, so it no longer matches the strict summary shape the script skips. Minimizing the card as resolved made the check pass.
Expected: a summary card whose listed findings all link to resolved review threads is not an open finding. Unresolved threads are already checked separately.
Acceptance:
- The check passes when every finding listed in the card links to a resolved thread.
- The check still fails when a listed finding's thread is unresolved or missing, and for any other bot comment shape.
scripts/check_codex_comments_test.sh covers both cases with fixtures.
Owner: maintainer desk. Not a required check today, so this is a false red, not a merge blocker.
Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: xhigh
The
Codex Commentscheck (scripts/check_codex_comments.sh) fails when the Codex Review Summary card lists a finding, even after that finding's review thread is resolved.Seen on #89 (head 13066a2): all review threads were resolved, and the latest Codex code and security reviews were clean. The check still failed with "1 unminimized regular comment from bot". The comment was the summary card: it now has a findings section that links to the resolved thread, so it no longer matches the strict summary shape the script skips. Minimizing the card as resolved made the check pass.
Expected: a summary card whose listed findings all link to resolved review threads is not an open finding. Unresolved threads are already checked separately.
Acceptance:
scripts/check_codex_comments_test.shcovers both cases with fixtures.Owner: maintainer desk. Not a required check today, so this is a false red, not a merge blocker.
Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:xhigh