Skip to content

🤖 ci: remove push trigger on main to avoid duplicate runs - #105

Merged
ammario merged 1 commit into
mainfrom
merge-group
Oct 8, 2025
Merged

ammario merged 1 commit into
mainfrom
merge-group

Conversation

@ammar-agent

Copy link
Copy Markdown
Collaborator

Changes

  • Remove push: branches: [main] from CI and Build workflows
  • Keep only merge_group and pull_request triggers
  • Docs workflow keeps push trigger (has path filters, only deploys)

Why

Currently, workflows run twice for every merge:

  1. Once when PR enters merge queue (merge_group event)
  2. Again after merging to main (push event)

This change eliminates the redundant post-merge runs, reducing CI costs and execution time.

Testing

After merge, verify that:

  • ✅ Workflows run on PR creation/updates
  • ✅ Workflows run when PR enters merge queue
  • ❌ Workflows do NOT run after merge to main (except Docs when docs change)

Bonus: propose_plan tool improvement

Also updated the propose_plan tool description to instruct the agent to always provide a recommendation when presenting options to the user.

Generated with cmux

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Comment thread src/components/VimTextArea.tsx Outdated
- Remove 'push: branches: [main]' from CI and Build workflows
- Keep only merge_group and pull_request triggers
- Workflows now run once in merge queue, not twice (queue + post-merge)
- Docs workflow keeps push trigger (has path filters, only deploys)
- Also updated propose_plan tool to recommend best option when presenting choices
@ammario
ammario enabled auto-merge October 8, 2025 20:44
@ammario
ammario added this pull request to the merge queue Oct 8, 2025
Merged via the queue into main with commit cdc142a Oct 8, 2025
6 checks passed
@ammario
ammario deleted the merge-group branch October 8, 2025 20:57
@mux-bot mux-bot Bot mentioned this pull request Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants