Repository navigation
fix(extraction): warn when parse errors leave no symbols (#1522) - #1799
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C++ raw strings with a 16-character delimiter can collapse the whole-file parse and silently leave only a file node. Emit a
parse_errorwarning only when the tree has errors and extraction yields zero non-file symbols, and display that warning in the CLI while keeping indexing successful.Related to #1522 (Half A). Grammar recovery remains a follow-up: the vendored grammar is unchanged, so the 16-character fixture still has no function symbols. Healthy empty/include-only files and partial parses with surviving symbols stay quiet.
Validation on Linux with Node 22.23.2:
npx vitest run __tests__/cpp-raw-string-delimiter-haserror.test.ts— 7 passed.npm run build— passed, including viewer and grammar asset checks.cli-parse-warning.test.ts,extraction.test.ts, andcli-index-explicit-path.test.tstogether — 650 passed.after_the_raw_string:/tmp/cg-1522-repro/d16/tmp/cg-1522-repro/d15