fix(resolution): follow alias bindings to the function they name (#1482) - #1808
Merged
Merged
Conversation
Adapt upstream PR #1485 by @valkyriweb (cc791cf) onto current main. Keep the upstream alias-binding module and six-test suite verbatim, preserve target-kind gating and default-export bindings, and add one credited Unreleased changelog entry. Linux verification (x86_64, Node 22.19.0): TypeScript build and asset copy pass; the fresh ./impl.js repro changes callers/impact of realImpl from missing consumerFn to including it. All 6 upstream tests and 231 related resolver regression tests pass. Fixes #1482 The Forge PR will supersede upstream PR #1485.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main: value aliases (export const alias = fn,export { fn as alias }, object-literal property refs, same-file aliases) forwardcallsedges to the aliased callable socallers/impactinclude consumers that call through the alias.gateTargetKind/resolveOneInnerstructure anddefaultBindingexport indexing; addssrc/resolution/alias-binding.tsand six focused tests from upstream verbatim.Linux verify (fail → pass)
On the issue's 2-file repro (
import { aliasName } from "./impl.js"):callers realImpl/impact realImplomitconsumerFnconsumerFn/consumer.ts__tests__/alias-binding-resolution.test.ts6/6; related resolver suites 231/231Test plan
tsc+ assetsconsumerFn