fix: stop callers/callees/impact silent fuzzy substitution (#1473) - #1809
Merged
Merged
Conversation
Adapt @uvmplus's PR #1481 (3ecf747) to the shared symbol lookup and named-symbol flow resolver on current main. Missing names return not found with suggestions, and exact matches with no callers stay empty. Preserve #1512 definition grouping and --file narrowing, #173 qualified misses, and codegraph_node's intentional fuzzy file lookup. Port the upstream regression suite and cover the moved shared lookup paths. Validation on Linux with Node 22: project build, 74 requested tests, 47 related flow tests, and 16 same-fixture CLI/MCP checks pass. Baseline captured 12 failing tests and 13 failing fixture checks. Fixes #1473. Supersedes #1481.
This was referenced Sep 9, 2026
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
callers/callees/impactno longer silently answer for a fuzzy FTS hit under the typed name (CLI + MCP).3ecf7479) onto post-CLIcallers/callees/impactmerge every same-named definition into one unlabeled result and expose no--file, while the MCP tools group and filter on the same index — the "CLI parity" surface returns a union true of no single definition — verified end-to-end #1512 shared resolvers (lookupSymbolNodes,findAllSymbolsinnamed-symbol-flow).#1512definition grouping /--filepreserved;codegraph_nodeintentional file-basename fuzzy left alone.Test plan
Calls,callsEf,Fetch,ef) — CLI + MCPnpx vitest run __tests__/no-silent-fuzzy-symbol.test.ts __tests__/symbol-lookup.test.ts __tests__/cli-definition-grouping.test.ts(74 passed)Supersedes #1481.