Skip to content

fix(graph): don't lose dependents within the depth limit to edge order (#1974) - #2000

Merged
colbymchenry merged 1 commit into
mainfrom
fix/1974-impact-depth
Sep 27, 2026
Merged

colbymchenry merged 1 commit into
mainfrom
fix/1974-impact-depth

Conversation

@colbymchenry

Copy link
Copy Markdown
Owner

Carries @danusha2345's #1991 onto current main (their commits, authorship preserved; the CHANGELOG entry is collected separately to avoid conflicts between the fix PRs).

Validation

Fixes #1974

🤖 Generated with Claude Code

#1974)

getImpactRadius, getCallers and getCallees are depth-limited DFS walks
with one visited set. A node first reached through a longer path at the
depth limit was marked visited without being expanded, so when a shorter
path reached it later it was skipped and its own dependents within the
limit were lost. Record the shallowest depth each node was expanded at
and expand it again when a nearer path reaches it. Results and edges are
still reported once, and output order is unchanged where nothing was
missing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit ec56377)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

impact --depth N misses dependents within N hops (depth-limited DFS marks nodes visited at the limit)

1 participant