fix(watcher): ignore Windows access-only notifications (#1451) - #2050
Merged
Merged
Conversation
Check indexed size and mtime before recording Windows watcher edits. Preserve scope reconciliation and fail open when metadata cannot be verified. Add native Windows regression coverage and validate on Windows, macOS, and Linux. Co-authored-by: JJordan0K <69581081+JJordan0C@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Windows NTFS access-time notifications incorrectly marked merely-read files as pending edits.
Fix
Build on #1472 to compare current size and mtime with indexed metadata before recording pending edits on Windows. Preserve scope changes and fail open for unknown, deleted, inaccessible, or unverifiable files. Add native watcher coverage and metadata-failure controls.
Validation
npx vitest run __tests__/watcher.test.ts: Windows 58 passed; macOS 51 passed, 7 skipped; Linux Docker 50 passed, 8 skipped.git diff --checkpassed.Fixes #1451
🤖 Generated with Claude Code