Skip to content

feat: implement issue #1297 — Synced stubs in ring repos carry a header naming v1-stable above a uses: line pinned to their ring — bots flag it and agents edit the stub to match - #1298

Open
don-petry wants to merge 63 commits into
mainfrom
dev-lead/issue-1297-20261011-0422
Open

don-petry wants to merge 63 commits into
mainfrom
dev-lead/issue-1297-20261011-0422

Conversation

@don-petry

@don-petry don-petry commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Synced stubs in ring repos carry a header naming v1-stable above a uses: line pinned to their ring — bots flag it and agents edit the stub to match

From the issue: The sweep re-pins a synced stub's uses: line (and agent_ref) to the target repo's ring, but leaves the stub's header comment naming the template's channel. In a ring-0 or ring-1 repo the two then disagree inside one file.

Risk

Low — 12 file(s) changed; no CI- or runtime-critical paths touched.

Test plan

Tests added/updated: test/scripts/deploy-standard-workflows/stub-header-tier-neutral.bats. Verification: bash scripts/dev-lead-lint.sh (shellcheck --severity=warning) ran pre-commit; the bats suite runs in CI.

Rollback

Revert this PR. No non-revertible side effects (no tags, migrations, or external state).

Monitoring

This PR's CI checks (Lint + bats) are the success/regression signal.

Closes #1297

View guided diff Turn on auto-fix

@don-petry
don-petry requested a review from a team as a code owner October 11, 2026 04:31
@don-petry don-petry added the auto-rebase:ready Opts a non-draft PR into auto-rebase without an approval (auto-rebase ready_label) label Oct 11, 2026
@gemini-code-assist

This comment has been minimized.

@chatgpt-codex-connector

This comment has been minimized.

@coderabbitai

This comment has been minimized.

@codeant-ai

codeant-ai Bot commented Oct 11, 2026

Copy link
Copy Markdown

CodeAnt Nitpicks

1 code suggestion

1. This only renders templates; the sweep skips existing pin-compliant consumer stubs, leaving their old stable-channel headers and the reported fleet mismatch in place.

Incomplete implementation · test/scripts/deploy-standard-workflows/stub-header-tier-neutral.bats:69-71

@codeant-ai

codeant-ai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

CodeAnt PR Risk: High Risk

  • The PR should not merge yet: ring-channel deployments may fail because ring_repin_uses passes the conditional sed options as one quoted script.

Assessed commit: 1eea28d63fff

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e38513943e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (not-applied)

A commit was pushed, but it did not touch any region the review named — the requested changes were not applied. Per requested item:

  • test/scripts/deploy-standard-workflows/stub-header-tier-neutral.bats:89 — not applied

@donpetry-bot

Copy link
Copy Markdown
Contributor

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-11T05:51:38Z.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cbe1e72208

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/deploy-standard-workflows.sh Resolved
Comment thread standards/workflows/pr-auto-review.yml Resolved
Comment thread standards/workflows/idea-enhancer.yml Resolved
Comment thread scripts/deploy-standard-workflows.sh Resolved
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@donpetry-bot

Copy link
Copy Markdown
Contributor

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-11T06:16:28Z.

@don-petry

Copy link
Copy Markdown
Contributor Author

No description provided.

@don-petry

Copy link
Copy Markdown
Contributor Author

This is a rate-limit notice from the bot — no code changes are needed. The PR has no actionable findings and all CI checks pass.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
## Summary
**Bot:** gemini-code-assist[bot]
**Issues addressed:** 0 (non-actionable notice)
**Notice handled:**
- Rate-limit notice ("reached your daily quota limit"): No code changes needed. This is an operational notice indicating the bot cannot process more requests. Posted informational disposition on the original comment.
**Files changed:** None
**Disposition:** Posted comment-disposition marker on the original bot comment ([IC_kwDORyesfc8AAAABa-nYyA](https://github.com/petry-projects/.github/pull/1298#issuecomment-6105971465)) with `disposition=informational`, as the notice contains no actionable code findings. All CI checks pass and the PR is in good state.

@don-petry
don-petry enabled auto-merge (squash) October 11, 2026 05:48
@gemini-code-assist

This comment has been minimized.

@don-petry
don-petry disabled auto-merge October 11, 2026 05:49
@don-petry

Copy link
Copy Markdown
Contributor Author

This is a quota-limit notice from the bot — no code changes required. All CI checks pass and no actionable code findings to address.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0 (quota-limit notice)
- Quota-limit notice: no actionable code findings — dispositioned as informational
Files changed: none
Skipped (informational): 1
```
The bot's comment is a **quota-limit operational notice**, not a code finding. All CI checks pass with no tier 1 blockers, and there are no actionable code issues to fix. The original comment has been dispositioned as `informational` per the non-actionable notice protocol.

@don-petry
don-petry enabled auto-merge (squash) October 11, 2026 05:50
@donpetry-bot

Copy link
Copy Markdown
Contributor

No description provided.

@don-petry
don-petry disabled auto-merge October 11, 2026 09:03
@don-petry

This comment has been minimized.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
## Summary
**Bot:** chatgpt-codex-connector[bot]
**Issues addressed:** 0 (non-actionable notice)
**Action taken:**
- Codex review summary (no findings): Posted `informational` disposition on [IC_kwDORyesfc8AAAABa-naxA](https://github.com/petry-projects/.github/pull/1298#issuecomment-6105455300) — the review shows only metadata (commit cbe1e72, review completed) with no specific findings or suggestions to address.
**Files changed:** None
**Disposition:** The Codex review comment is a neutral overview containing no actionable code findings. Posted disposition reply with `disposition=informational` marker. All CI checks pass, no Tier 1 blockers exist.

@don-petry
don-petry enabled auto-merge (squash) October 11, 2026 09:05
@don-petry

Copy link
Copy Markdown
Contributor Author

No description provided.

@don-petry
don-petry disabled auto-merge October 11, 2026 12:50

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 19a0d27337

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/deploy-standard-workflows.sh Resolved
@don-petry

Copy link
Copy Markdown
Contributor Author

No description provided.

@don-petry

Copy link
Copy Markdown
Contributor Author

No description provided.

…isting body in stale-header migration

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@don-petry

This comment has been minimized.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-reviews (partial)

A commit was pushed, but not every requested change was applied. Per requested item:

  • scripts/deploy-standard-workflows.sh:658 — not applied
  • scripts/deploy-standard-workflows.sh:1008 — applied

The unaddressed items above still need work.

@don-petry

Copy link
Copy Markdown
Contributor Author

No description provided.

@don-petry

This comment has been minimized.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-reviews (no-changes)

Agent reasoning
Addressed 0 threads with code changes. I made no commits and ran no tests, because nothing changed and CI is green except Analyze (actions), which was still running.
- **Thread `PRRT_kwDORyesfc6vc3ei`:** skipped, no new reply. Making `strip_stale_stable_header` render body comments tier-neutral, as the bot suggests, would contradict the bats test "strip_stale_stable_header with a template also drops a stale comment block under jobs". An earlier pass already left a reply on the thread, without the addressed-marker, so it stays open for a maintainer to decide between drop and rewrite. If they choose rewrite, that test needs a `Test-Change-Justification`.
- **Stale CodeRabbit comment `IC_kwDORyesfc8AAAABa-ncLg`:** I re-read its current body and posted a fresh `answered` disposition. It lists four items:
  - **Out-of-scope warning:** I'm keeping the idea-workflow tests, because this PR edits those three templates' headers.
  - **AC4 evidence:** the `template_stub_drift.sh` check lives in a separate private repo that I can't run from here. I said so and did not claim it was verified, so a maintainer needs to confirm it.
  - **Merge Risk:** the "overwrite customized workflow settings" and "test suite fails" findings are about the earlier reviewed commit; the current head's Lint and bats and bats checks pass.
  - **Housekeeping:** the paused review, Fix-CI and Autofix checkboxes need no action.
Test verification: not run. The cancelled `dev-lead / ci-relay`, `dispatch` and `resume` checks are this agent's own run being superseded.
Files changed: none.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ecc885f375

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/deploy-standard-workflows.sh Resolved
@don-petry

Copy link
Copy Markdown
Contributor Author

No description provided.

…der stub

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@don-petry

This comment has been minimized.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-reviews (partial)

A commit was pushed, but not every requested change was applied. Per requested item:

  • scripts/deploy-standard-workflows.sh:658 — not applied
  • scripts/deploy-standard-workflows.sh:1007 — applied

The unaddressed items above still need work.

@don-petry

Copy link
Copy Markdown
Contributor Author

No description provided.

@don-petry

This comment has been minimized.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-reviews (no-changes)

Agent reasoning
Addressed 0 threads; I made no code changes and did not run the test suite, since nothing changed.
- Thread `PRRT_kwDORyesfc6vc3ei`: skipped. Rendering the body comment lines tier-neutral conflicts with the existing bats test "strip_stale_stable_header with a template also drops a stale comment block under jobs". My earlier reply on the thread already says this, so I posted nothing new and left it open for a maintainer to decide between dropping and rewriting.
- CodeRabbit summary comment `IC_kwDORyesfc8AAAABa-ncLg` (the stale disposition): I read the current body and posted a fresh `answered` disposition. It covers the out-of-scope warning, the drift-check inconclusive item, the Merge Risk note and the review-paused notice.
- CI: the cancelled `dev-lead / ci-relay`, `dispatch` and `resume` checks come from the dev-lead run itself, not from this PR's code. `Analyze (actions)` was still running when I looked. I treated neither as blockers.
- There are no `CHANGES_REQUESTED` reviews.
Files changed: none.

@don-petry

Copy link
Copy Markdown
Contributor Author

No description provided.

@don-petry

Copy link
Copy Markdown
Contributor Author

No description provided.

@don-petry

Copy link
Copy Markdown
Contributor Author

No description provided.

@don-petry

Copy link
Copy Markdown
Contributor Author

Re-read the current CodeRabbit summary (edited after my earlier disposition). It holds no actionable inline comments, outside-diff items or nitpicks; the only new content is the paused-review notice and two pre-merge checks, so no code change:

  • Out of Scope Changes (warning): the idea-enhancer, idea-triage and initiative-planner tests exercise the present-only repo-template path that the stale-header detection and cleanup touch. They guard that this PR's header migration leaves customized bodies intact. They are kept as regression coverage, not as unrelated features.
  • Linked Issues (inconclusive): the template_stub_drift.sh compatibility check lives in .github-private and can't be run from this repo. It is a separate follow-up for a maintainer, not something this PR can evidence.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-reviews (no-changes)

Agent reasoning
Addressed 0 threads (no code changes; nothing committed):
- Thread PRRT_kwDORyesfc6vc3ei: skipped. I had already replied that the suggested change (render body comments tier-neutral instead of dropping them) conflicts with the bats test "strip_stale_stable_header with a template also drops a stale comment block under jobs". Whether the block should be dropped or rewritten is a maintainer decision, so the thread stays open and I added no new marker.
Phase 1b: posted a fresh `answered` disposition on the stale CodeRabbit summary comment IC_kwDORyesfc8AAAABa-ncLg.
- The edited body has no inline findings, outside-diff items or nitpicks. It only adds a "reviews paused" notice and two pre-merge checks.
- The out-of-scope warning is declined because the idea-workflow tests cover the present-only path this PR touches.
- The linked-issues item is the `template_stub_drift.sh` check in `.github-private`, which can't be run from this repo.
Tier 1 blockers: none. All CI checks passed or were skipped, and there are no CHANGES_REQUESTED reviews.
Test verification: not run, since nothing changed.
Files changed: none
```

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-rebase:ready Opts a non-draft PR into auto-rebase without an approval (auto-rebase ready_label)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Synced stubs in ring repos carry a header naming v1-stable above a uses: line pinned to their ring — bots flag it and agents edit the stub to match

2 participants