Refactor the global call-policy system, honor for implicit smart ptr conversions - #110
Merged
Merged
Conversation
aaronj0
force-pushed
the
smartptr-policy-flag
branch
from
September 23, 2026 18:01
077df5c to
9f03fdd
Compare
aaronj0
force-pushed
the
smartptr-policy-flag
branch
2 times, most recently
from
September 30, 2026 15:54
a8055ae to
d897cc0
Compare
aaronj0
added a commit
to aaronj0/root
that referenced
this pull request
Sep 30, 2026
…s [upstream] Consolidate the scattered per-policy globals into one flag word with a single accessor, so call-time policy checks read one place and new policies do not add module-level state. Matches compiler-research/cppjit#110.
aaronj0
added a commit
to aaronj0/root
that referenced
this pull request
Sep 30, 2026
…[upstream] SmartPtrConverter wrapped ordinary objects into the smart pointer unconditionally; respect the global implicit smart-pointer conversion policy like the other implicit-conversion sites. Matches compiler-research/cppjit#110.
aaronj0
added a commit
to aaronj0/root
that referenced
this pull request
Oct 1, 2026
…s [upstream] Consolidate the scattered per-policy globals into one flag word with a single accessor, so call-time policy checks read one place and new policies do not add module-level state. Matches compiler-research/cppjit#110.
aaronj0
added a commit
to aaronj0/root
that referenced
this pull request
Oct 1, 2026
…[upstream] SmartPtrConverter wrapped ordinary objects into the smart pointer unconditionally; respect the global implicit smart-pointer conversion policy like the other implicit-conversion sites. Matches compiler-research/cppjit#110.
aaronj0
added a commit
to aaronj0/root
that referenced
this pull request
Oct 1, 2026
…s [upstream] Consolidate the scattered per-policy globals into one flag word with a single accessor, so call-time policy checks read one place and new policies do not add module-level state. Matches compiler-research/cppjit#110.
aaronj0
added a commit
to aaronj0/root
that referenced
this pull request
Oct 1, 2026
…[upstream] SmartPtrConverter wrapped ordinary objects into the smart pointer unconditionally; respect the global implicit smart-pointer conversion policy like the other implicit-conversion sites. Matches compiler-research/cppjit#110.
aaronj0
added a commit
to aaronj0/root
that referenced
this pull request
Oct 1, 2026
…s [upstream] Consolidate the scattered per-policy globals into one flag word with a single accessor, so call-time policy checks read one place and new policies do not add module-level state. Matches compiler-research/cppjit#110.
aaronj0
added a commit
to aaronj0/root
that referenced
this pull request
Oct 1, 2026
…[upstream] SmartPtrConverter wrapped ordinary objects into the smart pointer unconditionally; respect the global implicit smart-pointer conversion policy like the other implicit-conversion sites. Matches compiler-research/cppjit#110.
aaronj0
added a commit
to aaronj0/root
that referenced
this pull request
Oct 2, 2026
…s [upstream] Consolidate the scattered per-policy globals into one flag word with a single accessor, so call-time policy checks read one place and new policies do not add module-level state. Matches compiler-research/cppjit#110.
aaronj0
added a commit
to aaronj0/root
that referenced
this pull request
Oct 2, 2026
…[upstream] SmartPtrConverter wrapped ordinary objects into the smart pointer unconditionally; respect the global implicit smart-pointer conversion policy like the other implicit-conversion sites. Matches compiler-research/cppjit#110.
aaronj0
added a commit
that referenced
this pull request
Oct 3, 2026
…s [upstream] Consolidate the scattered per-policy globals into one flag word with a single accessor, so call-time policy checks read one place and new policies do not add module-level state. Matches #110.
aaronj0
added a commit
that referenced
this pull request
Oct 3, 2026
…[upstream] SmartPtrConverter wrapped ordinary objects into the smart pointer unconditionally; respect the global implicit smart-pointer conversion policy like the other implicit-conversion sites. Matches #110.
aaronj0
added a commit
to root-project/root
that referenced
this pull request
Oct 3, 2026
…s [upstream] Consolidate the scattered per-policy globals into one flag word with a single accessor, so call-time policy checks read one place and new policies do not add module-level state. Matches compiler-research/cppjit#110.
aaronj0
added a commit
to root-project/root
that referenced
this pull request
Oct 3, 2026
…[upstream] SmartPtrConverter wrapped ordinary objects into the smart pointer unconditionally; respect the global implicit smart-pointer conversion policy like the other implicit-conversion sites. Matches compiler-research/cppjit#110.
guitargeek
previously approved these changes
Oct 5, 2026
guitargeek
left a comment
Collaborator
There was a problem hiding this comment.
LGTM!
On the long term I think all heuristics are confusing though and we should get rid of them.
Consolidate the scattered per-policy globals into one flag word with a single accessor, so call-time policy checks read one place and new policies do not add module-level state.
SmartPtrConverter wrapped ordinary objects into the smart pointer unconditionally; respect the global implicit smart-pointer conversion policy like the other implicit-conversion sites.
aaronj0
force-pushed
the
smartptr-policy-flag
branch
from
October 6, 2026 09:38
d897cc0 to
f0d4d90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.