Skip to content

fix ie7 problem of attribute class vs. className - #26

Closed
luobotang wants to merge 1 commit into
component:masterfrom
luobotang:master
Closed

luobotang wants to merge 1 commit into
component:masterfrom
luobotang:master

Conversation

@luobotang

Copy link
Copy Markdown

No description provided.

@stephenmathieson

Copy link
Copy Markdown
Contributor

@matthewmueller just changed this for svg support in 2aef7c5.

personally, i'd rather support svg than a super old browser.

@luobotang

Copy link
Copy Markdown
Author

Maybe you are right.
Maybe only a few people like me care about the super old browser.

@matthewmueller

Copy link
Copy Markdown
Member

Yah, I'm -1 unless we can come up with a solution that works for both. This is a heavily depended on module, so there should be no breaking changes at this point.

@luobotang

Copy link
Copy Markdown
Author

I have made a copy of this, 'fix' the IE7 problem then use it in my work. (I know, not a good way to do it)
The SVG support is currently not part of my work, but, I think find a solution for both is a better idea.

@matthewmueller

Copy link
Copy Markdown
Member

Okay :-) I'm going to close this for now. If you find some time to test both, let me know and I'll reopen.

@stephenmathieson

Copy link
Copy Markdown
Contributor

@luobotang no, forking is what components are all about. There's no reason you shouldn't maintain an IE7-friendly version of this component. Maybe someone else needs IE7 support but doesn't care about SVG. if I were you, I'd push a 2.0.0 tag out and start using your own version ;)

@luobotang

Copy link
Copy Markdown
Author

@stephenmathieson Maybe you're right.
But that's a little 'complicated' & 'confused' for me .... ^_^
Thanks for your reply. Now I know that the className problem is not a simply bug.
@matthewmueller Thank you too, for your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants