Add customization for welcome and header image texts - #67
Merged
Merged
Conversation
Contributor
|
This seems perfectly reasonable to me. @mbargull if you'd like to fix the merge conflicts, I'll be happy to merge. |
mbargull
force-pushed
the
welcome_header_text
branch
from
August 29, 2017 13:57
9e6ddb1 to
4e16a8c
Compare
Member
Author
|
Rebased! (This might conflict with branch mbargull:readme_support -- I'll rebase either one when the other one got merged.) |
Contributor
|
Thanks @mbargull. Merging. |
|
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds two new keys (
welcome_image_textandheader_image_text) which lets the user specify custom texts for the image generation. Use case: Installer name is too long for the width ofwelcome_image/header_image. Given the new keys, the user can provide multi-line texts to get around this problem (seeexamples/grin/construct.yaml).