Repository navigation
Conversation
The catalog OAuth form required authorization and token URLs even though registration discovers both from the issuer. Make empty values valid while still rejecting malformed non-empty URLs. Add a regression that submits empty endpoints for discovery. Ref #7464 Signed-off-by: Li Fengmin <2080291162@qq.com>
Microsoft-backed catalog entries publish the Entra ID issuer as a
template with a {tenantid} placeholder. Registering it verbatim stores
an issuer that cannot be fetched, so discovery and client registration
fail.
Show a required Tenant ID field whenever the issuer contains the
placeholder, and substitute the value into the issuer before submit.
The field disappears when the issuer no longer contains a placeholder.
Ref #7465
Signed-off-by: Li Fengmin <2080291162@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes IBM/mcp-context-forge#7465
Microsoft-backed catalog entries publish the Entra ID issuer as a template (
https://login.microsoftonline.com/{tenantid}/v2.0). Registering it verbatim stores an issuer the server cannot fetch, so discovery and client registration both fail.The OAuth catalog form now shows a required Tenant ID field whenever the issuer contains the placeholder, and substitutes the value into the issuer before submit. The field disappears when the issuer no longer contains a placeholder. Authorization and token URLs are unchanged: the Entra
common/organizationsendpoints accept any tenant, and registration compares only their origin.Stacked on #230 (both adjust this form's fields and validation); it will be rebased onto main once #230 merges.
Validation:
vitestCatalogOAuthForm + locale parity: 36 passednpm run typecheck